This ticket is in response to the release notes for the latest alpha version of EnhSim.
You say no'kaled procs are modeled as "a yellow attack without the ability to dodge and the damage can crit." This is rather vague. How, specifically, is the proc modeled in regards to crit % and crit damage bonus? A quick run of the sim with the
default config seems to indicate that the proc is using melee crit chance, but everything I have seen so far indicates that the proc crits for 150% damage and uses your spell crit chance for crit frequency determination. I haven't seen enough information to
say how it behaves with hit and expertise, but the log I'm including appears to not be spell hit capped (poisons are missing), and despite that the No'kaled procs are successfully connecting 100% of the time.
Here's a log for reference on No'kaled proc information:
Also, the modeling for Vial of Shadows seems off. From what I saw on the PTR, the proc scales at a rate of +1 AP = +0.9 average damage (this is exactly (33+1/3)% better than the observed scaling of the strength trinket (+1 AP = +0.675 average damage), presumably
to counteract the advantage the strength trinket has in AE situations). The proc appears to crit for 200% damage (not 150% as indicated by the EnhSim release notes).
Here's a log for reference on Vial of Shadows proc information: