Remove call of flame bonus from Fire Elemental's damage
Switched the Fire Elemental's melee swing over to fire damage from physical damage based on parses and testing.
Removed the physical vulnerability debuff from the Fire Elemental, since the melee damage is now fire based
Removed the melee crit chance buff from the Fire Elemental, since I can't find any evidence of the Fire Elemental ever gaining this buff. The Fire Elemental only gains debuffs.
Since the Fire Elemental only gets debuffs and not buffs, I switched the Fire Elemental to only getting the Spell Damage debuff so not to pick up any additional damage buffs, like from Sanctified Retribution
Reverted a change to use the base ap and spellpower from the main sim, and instead lock the ap and spellpower at time of cast. The previous base values didn't include any effect from stats like Agi, Int, etc. This ended up causing the Fire Elemental's damage to be very low.
Changed the stats display to show the average AP and SP when casting the Fire Elemental since it's locked at time of cast.
The Fire Elemental's five second rule event was not getting deleted when the FE was cancelled, which could cause an action to be fired after the FE was cancelled. This could cause a crash with the new swing timer interrupts.
The Fire Elemental's buff event was not getting deleting after being cancelled, which could cause the buff event to fire-off during a subsequent run.
The Fire Elemental's uptime was not correct if it was cancelled instead of having the buff wear off.
The Fire Elemental swing timer now gets interrupted during casts of Fire Nova and Fire Blast. The number of melee swings for the Fire Elemental should be much closer to how many there are during a typical boss fight.
Also cleaned up FireElemental::action to explicitly call castFireBlast and castFireNova for each case. The implicit fall-through will just cause somebody to get confused and both cases look similar now. I originally was doing this to fix up the possible FireNova stall introduced with a previous change, but that problem has already been addressed.